-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[Packaging] Build RPM for RHEL 9 and CentOS Stream 9 #23556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
azure-pipelines.yml
Outdated
| artifact: rpm-ubi9 | ||
| distro: el9 | ||
| image: registry.access.redhat.com/ubi9/ubi:9.0.0-1604 | ||
| python_package: python3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to use python3.9 to be explicit?
scripts/release/rpm/ubi9.dockerfile
Outdated
| @@ -0,0 +1,26 @@ | |||
| # Red Hat Universal Base Image 9: https://catalog.redhat.com/software/containers/ubi9/ubi/615bcf606feffc5384e8452e | |||
|
|
|||
| ARG tag=9.0.0-1604 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to use wider version like 9.0 to avoid bumping the version frequently.
scripts/release/rpm/ubi9.dockerfile
Outdated
| @@ -0,0 +1,26 @@ | |||
| # Red Hat Universal Base Image 9: https://catalog.redhat.com/software/containers/ubi9/ubi/615bcf606feffc5384e8452e | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reuse ubi8.dockerfile?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll make devel package be an arg.
In RHEL9, the valid names are python3.9-devel and python3-devel, but in RHEL8, python3.9-devel does not exists and python3-devel is for python3.6.
|
Packaging |
| python_package: python39 | ||
| Red Hat Universal Base Image 9: | ||
| dockerfile: ubi | ||
| image: registry.access.redhat.com/ubi9/ubi:9.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we unpin the last version?
| image: registry.access.redhat.com/ubi9/ubi:9.0.0 | |
| image: registry.access.redhat.com/ubi9/ubi:9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.0 returns 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed I got failure:
> docker run -it --rm registry.access.redhat.com/ubi9/ubi:9.0
Unable to find image 'registry.access.redhat.com/ubi9/ubi:9.0' locally
docker: Error response from daemon: error parsing HTTP 404 response body: invalid character 'N' looking for beginning of value: "Not found\n".
See 'docker run --help'.
Too much inconsistency! 😣
| image: fedora | ||
| tag: 35 | ||
| dockerfile: fedora | ||
| image: fedora:35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change! Much clearer and less cumbersome!
| dockerfile: ubi | ||
| image: registry.access.redhat.com/ubi9/ubi:9.0.0 | ||
| artifact: rpm-ubi9 | ||
| python_package: python3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python39 in RHEL 8 becames python3.9 in RHEL 9. It's bad design for RHEL 9 to introduce this inconsistency.
|
🚢 |
Description
Close #23101.
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.