Skip to content

Conversation

@bebound
Copy link
Contributor

@bebound bebound commented Aug 17, 2022

Description

Close #23101.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested review from jiasli, kairu-ms, wangzelin007 and yonzhan August 17, 2022 07:08
@ghost ghost added the Auto-Assign Auto assign by bot label Aug 17, 2022
@ghost ghost assigned jiasli Aug 17, 2022
@ghost ghost added this to the Aug 2022 (2022-09-06) milestone Aug 17, 2022
@ghost ghost added the Packaging label Aug 17, 2022
artifact: rpm-ubi9
distro: el9
image: registry.access.redhat.com/ubi9/ubi:9.0.0-1604
python_package: python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to use python3.9 to be explicit?

@@ -0,0 +1,26 @@
# Red Hat Universal Base Image 9: https://catalog.redhat.com/software/containers/ubi9/ubi/615bcf606feffc5384e8452e

ARG tag=9.0.0-1604
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use wider version like 9.0 to avoid bumping the version frequently.

@@ -0,0 +1,26 @@
# Red Hat Universal Base Image 9: https://catalog.redhat.com/software/containers/ubi9/ubi/615bcf606feffc5384e8452e
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse ubi8.dockerfile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll make devel package be an arg.

In RHEL9, the valid names are python3.9-devel and python3-devel, but in RHEL8, python3.9-devel does not exists and python3-devel is for python3.6.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 17, 2022

Packaging

@bebound bebound marked this pull request as ready for review August 22, 2022 06:33
@bebound bebound requested a review from calvinhzy as a code owner August 22, 2022 06:33
python_package: python39
Red Hat Universal Base Image 9:
dockerfile: ubi
image: registry.access.redhat.com/ubi9/ubi:9.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we unpin the last version?

Suggested change
image: registry.access.redhat.com/ubi9/ubi:9.0.0
image: registry.access.redhat.com/ubi9/ubi:9.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9.0 returns 404.

Copy link
Member

@jiasli jiasli Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I got failure:

> docker run -it --rm registry.access.redhat.com/ubi9/ubi:9.0
Unable to find image 'registry.access.redhat.com/ubi9/ubi:9.0' locally
docker: Error response from daemon: error parsing HTTP 404 response body: invalid character 'N' looking for beginning of value: "Not found\n".
See 'docker run --help'.

Too much inconsistency! 😣

image: fedora
tag: 35
dockerfile: fedora
image: fedora:35
Copy link
Member

@jiasli jiasli Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change! Much clearer and less cumbersome!

dockerfile: ubi
image: registry.access.redhat.com/ubi9/ubi:9.0.0
artifact: rpm-ubi9
python_package: python3.9
Copy link
Member

@jiasli jiasli Aug 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python39 in RHEL 8 becames python3.9 in RHEL 9. It's bad design for RHEL 9 to introduce this inconsistency.

@jiasli
Copy link
Member

jiasli commented Aug 23, 2022

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Packaging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release RPMs for RHEL 9 and CentOS Stream 9

3 participants